Add a parameter 'registry_project_id' to the GKE module templates #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmontan
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
reviewed
Oct 4, 2019
There was a problem hiding this comment.
The core change looks fine.
For testing, could we consider adding these tests to an existing suite? GKE tests are unfortunately very long so I'd like to avoid the proliferation of test suites so we don't make integration tests run even longer than they already do.
The PR allows configuring the project holding the GCR registry when used in connection with 'create_service_account'=true and grant_registry_access=true. Holding the GCR is a project with other resources increases the risk of exposing sensitive data to the service account running the nodes, as the required permissions of role roles/storage.objectViewer provide access to all storage objects in the project.
mmontan
force-pushed
the
custom-gcr-project
branch
from
6b90fc5
to
55ade20
Compare
|
The Cloud Build check pass now. I can't access logs from the concourse builds, so it's hard to debug them. How do I find the logs? |
You can ignore Concourse tests. They're legacy and no longer needed. |
morgante
approved these changes
Oct 17, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…cr-project Add a parameter 'registry_project_id' to the GKE module templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR allows configuring the project holding the GCR registry when
used in connection with 'create_service_account'=true and
grant_registry_access=true.
Holding the GCR is a project with other resources increases the risk of
exposing sensitive data to the service account running the nodes, as the
required permissions of role roles/storage.objectViewer provide access
to all storage objects in the project.