-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: allow passing $TFLINT_INSTALL_PATH
#1183
Conversation
on windows, this file was moved powershell rm seems to ignore missing by default
$SUDO install -b -c -v /tmp/tflint /usr/local/bin/ | ||
|
||
$SUDO mkdir -p "$dest" | ||
$SUDO install -b -c -v /tmp/tflint "$dest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be neat to also control whether it should be installed as root or not. My use case is having a fully non-interactive, isolated (as in, installs to a custom path and doesn't tamper with anything system-wide/global), installation process. Wdyt?
# ¯\_(ツ)_/¯
TFLINT_INSTALL_NO_ROOT=1
TFLINT_INSTALL_NO_SUDO=1
TFLINT_INSTALL_SKIP_SUDO=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #1184 with my suggestions, thanks for looking into this!
Supports a custom install path,
$TFLINT_INSTALL_PATH
, with the previous path as the default.Fixes #1179