update install script to better support non-PATH installations #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
commented
Aug 14, 2021
install_linux.sh
Outdated
| SUDO="sudo"; | ||
| fi | ||
|
|
||
|
|
||
| $SUDO mkdir -p "$dest" | ||
| $SUDO install -b -c -v /tmp/tflint "$dest" | ||
| $SUDO install --backup=none -c -v /tmp/tflint "$dest" |
There was a problem hiding this comment.
Perhaps scope creeping a but - but I suggest we change this to not create any backup, to avoid polluting the PATH. What happens now if you run the install script more than once is that you'll end up with a tflint and tflint~ (the backup) in in your install destination.
bendrucker
reviewed
Aug 15, 2021
install_linux.sh
Outdated
| @@ -68,13 +70,13 @@ else | |||
| dest="${TFLINT_INSTALL_PATH:-/usr/local/bin}/" | |||
| echo "Installing /tmp/tflint to ${dest}..." | |||
|
|
|||
| if [[ "$(id -u)" == 0 ]]; then SUDO=""; else | |||
| if [[ "$(id -u)" == 0 ]] || [[ $TFLINT_INSTALL_NO_ROOT == 1 ]]; then SUDO=""; else | |||
There was a problem hiding this comment.
Seems like the script should just test whether it can access the directory as the non-root user and use sudo if not rather than adding an option
There was a problem hiding this comment.
Good call 👍 a80c763
install_linux.sh
Outdated
| @@ -4,6 +4,8 @@ processor=$(uname -m) | |||
|
|
|||
| if [ "$processor" == "x86_64" ]; then | |||
| arch="amd64" | |||
| elif [ "$processor" == "arm64" ]; then | |||
There was a problem hiding this comment.
If you could submit this separately happy to merge it right away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.