Fix a false positive for log-delivery-write ACL
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
fix_false_positive_for_s3_bucket_acl
branch
from
0980274
to
1e50fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Unfortunately, BucketCannedACL defined by aws-sdk seems incomplete. There may be other false positives/negatives with similar causes, but here, only the aws_s3_bucket_invalid_acl rule is switched to the manual way, and fix the false positive.
In the future, it may be necessary to consider how to generate the valid values list from different definitions than the aws-sdk. But in that case, the challenge is how to keep up-to-date the definition.