Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false positive for log-delivery-write ACL #355

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Fix a false positive for log-delivery-write ACL #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...rules/models/aws_s3_bucket_invalid_acl.go → rules/awsrules/aws_s3_bucket_invalid_acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// This file generated by `tools/model-rule-gen/main.go`. DO NOT EDIT

package models
package awsrules

import (
"log"
Expand All @@ -27,6 +25,7 @@ func NewAwsS3BucketInvalidACLRule() *AwsS3BucketInvalidACLRule {
"public-read",
"public-read-write",
"authenticated-read",
"log-delivery-write",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion rules/awsrules/models/mappings/s3.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ mapping "aws_s3_account_public_access_block" {
mapping "aws_s3_bucket" {
bucket = BucketName
bucket_prefix = any
acl = BucketCannedACL
acl = any // TODO: BucketCannedACL
policy = Policy
tags = TagSet
force_destroy = any
Expand Down
1 change: 1 addition & 0 deletions rules/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var manualRules = []Rule{
awsrules.NewAwsInstancePreviousTypeRule(),
awsrules.NewAwsRouteNotSpecifiedTargetRule(),
awsrules.NewAwsRouteSpecifiedMultipleTargetsRule(),
awsrules.NewAwsS3BucketInvalidACLRule(),
terraformrules.NewTerraformDocumentedOutputsRule(),
terraformrules.NewTerraformDocumentedVariablesRule(),
terraformrules.NewTerraformModulePinnedSourceRule(),
Expand Down
1 change: 0 additions & 1 deletion rules/provider_model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ var modelRules = []Rule{
awsmodelrules.NewAwsRoute53ZoneInvalidDelegationSetIDRule(),
awsmodelrules.NewAwsRoute53ZoneInvalidNameRule(),
awsmodelrules.NewAwsS3BucketInvalidAccelerationStatusRule(),
awsmodelrules.NewAwsS3BucketInvalidACLRule(),
awsmodelrules.NewAwsS3BucketInvalidRegionRule(),
awsmodelrules.NewAwsS3BucketInvalidRequestPayerRule(),
awsmodelrules.NewAwsS3BucketInventoryInvalidIncludedObjectVersionsRule(),
Expand Down