Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check invalid rule names in command line options (fixes #470) #496

Merged
merged 3 commits into from
Nov 3, 2019

Conversation

abitrolly
Copy link
Contributor

Exit with an error when --enable-rule name is not found.

Also adds INFO level stats about total amount of rules and enabled rules.

…ters#470)

Exit with an error when --enable-rule name is not found.

Also adds INFO level stats about total amount of rules and enabled
rules.
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for your contribution!
I left some suggestions, please confirm.

cmd/cli.go Show resolved Hide resolved
cmd/cli.go Show resolved Hide resolved
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm planning to merge this pull request when publishing v0.13.

@wata727 wata727 added this to the v0.13.0 milestone Oct 22, 2019
@wata727 wata727 merged commit 35d228e into terraform-linters:master Nov 3, 2019
@abitrolly abitrolly deleted the rule-name-check branch November 3, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants