Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: extend provider "max_retries" argument #1159

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Core: extend provider "max_retries" argument #1159

merged 1 commit into from
Feb 2, 2021

Conversation

kayrus
Copy link
Collaborator

@kayrus kayrus commented Feb 2, 2021 •
edited

This PR allows to configure terraform to detect the 429 response code with a Retry-After header and sleep to reduce the load on API.

Fixes #1156

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 2, 2021

Build succeeded.

@kayrus
Copy link
Collaborator Author

kayrus commented Feb 2, 2021

@ozerovandrei ready for review

@dkistner dkistner mentioned this pull request Feb 2, 2021
Closed
ozerovandrei
ozerovandrei approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit bb3539f into terraform-provider-openstack:main Feb 2, 2021
@kayrus kayrus deleted the retry-logic branch February 2, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core: provider should honor the 429 response code with a Retry-After header
2 participants
@kayrus @ozerovandrei