Update openstack terraform provider configuration

[kayrus]

How to categorize this issue?

/area usability
/kind enhancement
/priority normal
/platform openstack

What would you like to be added:

Current provider configuration should be adjusted:

gardener-extension-provider-openstack/charts/internal/openstack-infra/templates/main.tf

Lines 1 to 9 in 9110734

	provider "openstack" {
	auth_url = "{{ required "openstack.authURL is required" .Values.openstack.authURL }}"
	domain_name = "{{ required "openstack.domainName is required" .Values.openstack.domainName }}"
	tenant_name = "{{ required "openstack.tenantName is required" .Values.openstack.tenantName }}"
	region = "{{ required "openstack.region is required" .Values.openstack.region }}"
	user_name = var.USER_NAME
	password = var.PASSWORD
	insecure = true
	}

Insecure flag must be removed:

insecure    = true

And a max_retries should be set in order support the 429 response code with a Retry-After header.

Why is this needed:

• Production environment must not contain the insecure=true parameter.
• max_retries starting from Terrafrom OpenStack provider v1.36 will support the 429 response code and sleep accordingly. This is needed in order to decrease high amount of API calls, when a technical user password was changed and a user gets blocked by identity.

[dkistner]

/assign

We wait until openstack terraform provider which incorporate terraform-provider-openstack/terraform-provider-openstack#1159 is released and Terraformer will adopt this new release.

[dkistner]

Status

• Add max retries → Add max retries to repeat failed or throttled operations #222
• Remove insecure=true require to have the ability passing a proper CA cert to secure the TLS connections

[kayrus]

it looks like the corresponding changes are already implemented:

gardener-extension-provider-openstack/pkg/internal/infrastructure/templates/main.tpl.tf

Lines 19 to 22 in 31ecded

	max_retries = "{{ .openstack.maxApiCallRetries }}"
	{{ if .openstack.insecure }}
	insecure = true
	{{ end }}