Aws Config Remediation #13884

cgetzen · 2020-06-22T23:21:41Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Adds aws_config_remediation_configuration resource

Answering hashicorp#7972 This is my 1st go development ever, so please feel free to tell me if I did something in a bad way, which is most probable :) feat(go): learn pointers usage feat(config): parse all simple fields chore(naming): replace ConfigRule by RemediationConfiguration feat(config): add read flatten function feat(config): add delete function feat(config): use TypeSet instead of TypeList, & parse ResourceValue feat(config): parse StaticValue feat(config) flatten remediation config parameters to nil, just to get the function signature right feat(config): flatten remediation config parameters

chore(tidy): remove unused import comments test(config): copy-paste config rule test to start from something feat(test): add shredder feat(config): add a remediation configuration exemple feat(test): add getter check feat(config): add 1st finished acc test feat(test): remove unadapted commented tests & add a second true test feat(test): add static values tests chore(fmt): format the file with make fmt fixup! chore(fmt): format the file with make fmt fix(test): add required on fields chore(lint): proceed with linter results chore(lint): use correct configuration

cgetzen · 2020-07-14T00:09:52Z

@gdavison I've addressed your comments from #9348. I'm wondering if you have any time to take a look at this. This will close #7972. Thank you!

teamterraform · 2020-08-18T21:21:32Z

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

gdavison

Thanks, @cgetzen , this looks great! Thanks for picking up the PR

There are a couple minor changes to make, and we'd like to see a few more tests added to the acceptance tests.

aws/resource_aws_config_remediation_configuration.go

aws/resource_aws_config_remediation_configuration_test.go

gdavison · 2020-08-27T17:40:19Z

aws/resource_aws_config_remediation_configuration_test.go

+		},
+	})
+}
+


We should also add tests for:

changes that will update the rule in-place

changes that will force a new resource

aws/resource_aws_config_remediation_configuration_test.go

website/aws.erb

Terraform plugin SDK v2 Co-authored-by: Graham Davison <g.m.davison@computer.org>

Wrap AWS API error Co-authored-by: Graham Davison <g.m.davison@computer.org>

Remove double read Co-authored-by: Graham Davison <g.m.davison@computer.org>

Terraform Plugin SDK v2 Co-authored-by: Graham Davison <g.m.davison@computer.org>

resourceName Co-authored-by: Graham Davison <g.m.davison@computer.org>

…aform-provider-aws into f-aws_config_remediation

cgetzen · 2020-09-15T03:38:56Z

Hi @gdavison, thanks for the thorough review. I've made all the minor changes and added the acceptance tests "recreates", "updates", and "disappears".

        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/basic (110.32s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/disappears (98.59s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/recreates (126.61s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/updates (122.40s)

gdavison

LGTM 🚀

Acceptance tests:

--- PASS: TestAccAWSConfig_serial/RemediationConfiguration (338.52s)
    --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/basic (81.33s)
    --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/disappears (77.77s)
    --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/recreates (91.55s)
    --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/updates (87.87s)

aws/resource_aws_config_remediation_configuration.go

ghost · 2020-09-17T23:32:32Z

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-10-17T17:10:49Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Patrick Laxton and others added 6 commits June 19, 2020 09:42

feedback(pr): 1st lot

06a307b

feedback(pr): 2nd lot

d3d3b17

feedback(pr): 3rd lot

604c6a9

update to recent version

5cb06a2

cgetzen requested a review from a team June 22, 2020 23:21

cgetzen force-pushed the f-aws_config_remediation branch from 0e58b74 to f09dab2 Compare June 22, 2020 23:30

documentation

b9d6c0c

cgetzen force-pushed the f-aws_config_remediation branch from f09dab2 to b9d6c0c Compare June 22, 2020 23:40

This was referenced Jun 22, 2020

feature(config): manage AWS Config Remediation Configuration #9348

Closed

Support ConfigService Remediation Configuration #7972

Closed

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

gdavison requested changes Aug 27, 2020

View reviewed changes

gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label Aug 27, 2020

gdavison self-assigned this Aug 27, 2020

gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Aug 27, 2020

cgetzen and others added 5 commits August 30, 2020 14:32

Update aws/resource_aws_config_remediation_configuration.go

834e417

Terraform plugin SDK v2 Co-authored-by: Graham Davison <g.m.davison@computer.org>

Update aws/resource_aws_config_remediation_configuration.go

327b183

Wrap AWS API error Co-authored-by: Graham Davison <g.m.davison@computer.org>

Update aws/resource_aws_config_remediation_configuration.go

4ae7afa

Remove double read Co-authored-by: Graham Davison <g.m.davison@computer.org>

Update aws/resource_aws_config_remediation_configuration_test.go

943e342

Terraform Plugin SDK v2 Co-authored-by: Graham Davison <g.m.davison@computer.org>

Update aws/resource_aws_config_remediation_configuration_test.go

44b08d0

resourceName Co-authored-by: Graham Davison <g.m.davison@computer.org>

charliegetzen-okta and others added 6 commits August 30, 2020 14:39

remove website changes

3390d4c

Merge branch 'master' of github-personal.com:terraform-providers/terr…

8bf3715

…aform-provider-aws into f-aws_config_remediation

documentation formatting

6d8b7e6

only pass repeated parameter once

5afda14

Add test for out-of-band deletion

7073583

Add test for recreation

57a4373

cgetzen force-pushed the f-aws_config_remediation branch from 0c5bc38 to 57a4373 Compare September 7, 2020 22:48

cgetzen added 5 commits September 8, 2020 01:49

Add test for updates

93f95b2

All acceptance tests pass

5b2973c

linting terraform

57fe47e

linting go

ae16b2c

linting go (2)

f6e73d2

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 15, 2020

gdavison approved these changes Sep 16, 2020

View reviewed changes

aws/resource_aws_config_remediation_configuration.go Outdated Show resolved Hide resolved

gdavison added 2 commits September 16, 2020 13:27

Update aws/resource_aws_config_remediation_configuration.go

2739db6

Adds package name and fixes formatting

7399705

gdavison merged commit d4291c9 into hashicorp:master Sep 16, 2020

gdavison added this to the v3.7.0 milestone Sep 16, 2020

gdavison added a commit that referenced this pull request Sep 16, 2020

Update CHANGELOG for #13884

21218b0

cgetzen mentioned this pull request Sep 17, 2020

AWS Config Remediation Configuration (squashed) #13885

Closed

hashicorp locked as resolved and limited conversation to collaborators Oct 17, 2020

cgetzen deleted the f-aws_config_remediation branch October 21, 2020 01:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aws Config Remediation #13884

Aws Config Remediation #13884

cgetzen commented Jun 22, 2020 •

edited by gdavison

cgetzen commented Jul 14, 2020

teamterraform commented Aug 18, 2020

gdavison left a comment

gdavison Aug 27, 2020

cgetzen commented Sep 15, 2020

gdavison left a comment

ghost commented Sep 17, 2020

ghost commented Oct 17, 2020

Aws Config Remediation #13884

Aws Config Remediation #13884

Conversation

cgetzen commented Jun 22, 2020 • edited by gdavison

Community Note

cgetzen commented Jul 14, 2020

teamterraform commented Aug 18, 2020

Notification of Recent and Upcoming Changes to Contributions

Terraform 0.12 Syntax

Action Required: Terraform Plugin SDK Version 2

Action Required: Removal of website/aws.erb File

Upcoming Change of Git Branch Naming

Upcoming Change of GitHub Organization

gdavison left a comment

Choose a reason for hiding this comment

gdavison Aug 27, 2020

Choose a reason for hiding this comment

cgetzen commented Sep 15, 2020

gdavison left a comment

Choose a reason for hiding this comment

ghost commented Sep 17, 2020

ghost commented Oct 17, 2020

cgetzen commented Jun 22, 2020 •

edited by gdavison