Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: Allow all valid app identifier URI schemes #115

Merged
merged 1 commit into from
Jul 5, 2019
Merged

azuread_application: Allow all valid app identifier URI schemes #115

merged 1 commit into from
Jul 5, 2019

Conversation

manicminer
Copy link
Member

As per the Azure Portal, the following schemes are allowed for application ID URIs:

  • https
  • api
  • urn
  • ms-appx

Screenshot 2019-07-02 14 08 28

This change allows these URI schemes to be used, and also retains the already-allowed http scheme for compatibility (since that was already allowed, then disallowed, then allowed again in the azurerm provider).

Screenshot 2019-07-02 14 08 54

Tests are passing locally for me but I haven't run acceptance tests.

@ghost ghost added the size/S label Jul 2, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit eeaab4b into hashicorp:master Jul 5, 2019
@katbyte katbyte added this to the v0.5.0 milestone Jul 5, 2019
katbyte added a commit that referenced this pull request Jul 5, 2019
@ghost
Copy link

ghost commented Jul 24, 2019

This has been released in version 0.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.5.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants