Application improvements #474

manicminer · 2021-06-30T14:34:01Z

Case insensitive matching on UUIDs for passwords and certificates
Role/scope validation also checks IDs now that users must set it themselves
Extensive whole-resource validation when sign_in_audience is changed to include personal accounts, to avoid breakage
Updates Hamilton to v0.20.0 for fixes, features and improved odata query support

New Applications Features

Support additional properties in the api block
- accept_mapped_claims
- known_client_applications
- requested_access_token_version
Export the disabled_by_microsoft attribute
Support the logo_url, marketing_url, privacy_statement_url, support_url and terms_of_service_url properties
Support the device_only_auth_enabled property
Support the oauth2_post_response_required property
Export the publisher_domain attribute (this is readonly, awaiting feedback on how we can set this)
Support the public_client block
Support the single_page_application block
Export two computed typemap attributes: app_role_ids and oauth2_permission_scope_ids to alleviate typeset handling with config boilerplate

Closes: #188
Closes: #244
Closes: #286
Closes: #320
Closes: #436
Closes: #462
Closes: #469
Closes: #477

katbyte

aside from a few comments on schema this looks good!

internal/services/applications/application_data_source.go

internal/services/applications/application_resource.go

katbyte · 2021-07-01T00:20:42Z

internal/services/applications/application_resource.go

+			},
+
+			"oauth2_post_response_required": {
+				Description: "Specifies whether, as part of OAuth 2.0 token requests, Azure AD allows POST requests, as opposed to GET requests.",


this says "post allowed" vs the property name "response_required"

This is a tricky one since the docs are ambiguous on the behaviour. I'll try to dig up the actual meaning and make it clearer one way or the other.

It seems like this description, which was pulled from application manifest docs, is the only documentation available on this one. Will follow up separately and try to find out more.

any update on this one?

Not as yet, have reached out to get some clarity on this field

I've raised this separately as #491 against the 2.0.0 milestone in order to unblock the PR stack :)

internal/services/applications/application_resource.go

manicminer · 2021-07-02T13:47:12Z

@katbyte I've added some additional validation to try and avoid applying bad application configurations; could you take another look before merging? Thanks! :)

manicminer · 2021-07-04T00:07:37Z

~~This is unfortunately blocked due to a plugin SDK issue around block handling~~ Resolved with diff suppress func

manicminer · 2021-07-04T18:20:29Z

Test results

katbyte

aside from a couple comments LGTM 🍰

katbyte · 2021-07-06T14:31:23Z

internal/services/applications/application_data_source.go

@@ -252,6 +349,35 @@ func applicationDataSource() *schema.Resource {
 				Computed:    true,
 			},

+			"single_page_application": {


if this is a list shouldn't it be plural?

Suggested change

"single_page_application": {

"single_page_applications": {

This block is intended to contain the settings for the application when it's functioning as a single page app (the API container is just spa but I felt it needed expanding)

katbyte · 2021-07-06T14:32:27Z

internal/services/applications/application_resource.go

+			},
+
+			"oauth2_post_response_required": {
+				Description: "Specifies whether, as part of OAuth 2.0 token requests, Azure AD allows POST requests, as opposed to GET requests.",


any update on this one?

- accept_mapped_claims - known_client_applications - requested_access_token_version

…locks

…he new `public_client` block

…ids` attributes. Resolve unwanted diffs with a big DiffSuppressFunc instead of selecting setting attributes in state

github-actions · 2021-08-21T02:05:01Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

manicminer added enhancement feature/applications api/microsoft-graph labels Jun 30, 2021

manicminer added this to the v2.0.0 milestone Jun 30, 2021

manicminer changed the base branch from main to v2 June 30, 2021 14:34

This was linked to issues Jun 30, 2021

Support accessTokenAcceptedVersion in azuread_application #188

Closed

Support reply_url type Spa on azuread_application #244

Closed

Add support for SPA based application clients using PKCE flow #286

Closed

Add support for publicClient #436

Closed

manicminer marked this pull request as ready for review June 30, 2021 23:24

manicminer mentioned this pull request Jun 30, 2021

applications schema - add on_premise_security_identifier #463

Closed

manicminer requested a review from a team July 1, 2021 00:00

katbyte approved these changes Jul 1, 2021

View reviewed changes

Base automatically changed from v2 to main July 2, 2021 08:40

manicminer requested a review from katbyte July 2, 2021 13:47

manicminer modified the milestones: v2.0.0, Blocked Jul 4, 2021

manicminer modified the milestones: Blocked, v2.0.0 Jul 4, 2021

katbyte approved these changes Jul 6, 2021

View reviewed changes

manicminer mentioned this pull request Jul 6, 2021

Please support knownClientApplications #477

Closed

simaotwx mentioned this pull request Jul 19, 2021

Add support for SPA based application clients using PKCE flow #286

Closed

manicminer added 5 commits July 21, 2021 22:02

Case insensitive matching on UUIDs

435f6cc

Applications: support additional properties in the api block

ee3b8aa

- accept_mapped_claims - known_client_applications - requested_access_token_version

Applications: export the disabled_by_microsoft_status attribute

7365185

Applications: support the info block

9dec08c

Applications: support the device_only_auth_enabled property

b4291ad

manicminer and others added 15 commits July 21, 2021 22:03

Applications: support the oauth2_post_response_required property

94a2faf

Applications: export the publisher_domain attribute

5f19506

Upgrade hamilton to v0.20.0 which includes improved odata query support

edf5808

Applications: support the public_client and single_page_application b…

956944a

…locks

Applications: support "on_premise_security_identifier" optional claim

dc5588d

Applications: move informational URL properties to the top level

c5e5590

Applications: rename accept_mapped_claims for consistency

d0105cd

Clarify the difference between the old public_client property and t…

7b35795

…he new `public_client` block

Rename disabled_by_microsoft_status

7824fac

Applications: identifier_uris validation for URNs

e9d83bd

Additional validation for applications

2a1e295

Remove unused resource ID parser

ff5fe2d

Fix attribute typo

a2c57d5

Applications: export the app_role_ids and `oauth2_permission_scope_…

a2ea1f9

…ids` attributes. Resolve unwanted diffs with a big DiffSuppressFunc instead of selecting setting attributes in state

Doc cleanup

cdf4f18

manicminer force-pushed the f/application-improvements branch from 2770927 to cdf4f18 Compare July 21, 2021 21:03

github-actions bot added dependencies size/XL labels Jul 21, 2021

manicminer merged commit 48f63a6 into main Jul 21, 2021

manicminer deleted the f/application-improvements branch July 21, 2021 22:15

manicminer added a commit that referenced this pull request Jul 21, 2021

Changelog for #474

8920f02

manicminer mentioned this pull request Jul 21, 2021

Applications: get clarity on oauth2_post_response_required field #491

Open

JonasKop mentioned this pull request Jul 28, 2021

Create SPA type in terraform setup config Omegapoint/Kompassen-2.0#76

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Application improvements #474

Application improvements #474

manicminer commented Jun 30, 2021 •

edited

Loading

katbyte left a comment

katbyte Jul 1, 2021

manicminer Jul 1, 2021

manicminer Jul 2, 2021

katbyte Jul 6, 2021

manicminer Jul 7, 2021

manicminer Jul 21, 2021

manicminer commented Jul 2, 2021

manicminer commented Jul 4, 2021 •

edited

Loading

manicminer commented Jul 4, 2021

katbyte left a comment

katbyte Jul 6, 2021

manicminer Jul 6, 2021

katbyte Jul 6, 2021

github-actions bot commented Aug 21, 2021

Application improvements #474

Application improvements #474

Conversation

manicminer commented Jun 30, 2021 • edited Loading

New Applications Features

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manicminer commented Jul 2, 2021

manicminer commented Jul 4, 2021 • edited Loading

manicminer commented Jul 4, 2021

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2021

manicminer commented Jun 30, 2021 •

edited

Loading

manicminer commented Jul 4, 2021 •

edited

Loading