New resource 'azuread_group_member' #63

tiwood · 2019-03-13T17:05:01Z

This adds a new resource to manage Azure AD Group Membership with Terraform.

New resource 'azuread_group_member'
Add tests
Add documentation

Example Usage

data "azuread_user" "my_user" {
  user_principal_name = "johndoe@hashicorp.com"
}

resource "azuread_group" "my_group" {
  name = "my_group"
}

resource "azuread_group_member" "test" {
  group_object_id   = "${azuread_group.my_group.id}"
  member_object_id  = "${data.azuread_user.my_user.id}"
}

Argument Reference

The following arguments are supported:

group_object_id - (Required) The Object ID of the Azure AD Group you want to add the Member to.
member_object_id - (Required) The Object ID of the Azure AD Object you want to add as a Member to the Group. Supported Object types are Users, Groups or Service Principals.

tiwood · 2019-03-13T17:19:17Z

Related: #36

tiwood · 2019-04-04T11:11:35Z

@tombuildsstuff @katbyte
any idea when this can be reviewed?
Thanks!

katbyte · 2019-04-12T05:00:57Z

@tiwood, we are currently busy with .12 and some work on the azurerm provider. Unfortunately I can't make any promises but I hope to earmark some time towards azuread in a couple weeks near the end of the month.

katbyte · 2019-04-12T05:02:06Z

Additionally i'd like to support setting group members via the group resource itself at the same time this is released.

tiwood · 2019-05-06T14:31:22Z

I will look into this in the next days.

katbyte

Hi @tiwood,

Thanks for the resource. Overall this looks pretty good to me and i've only left a couple comment inline. I would like to see support for setting group members from the group resource at the same time we merge this. If thats to big of ask let me know and i am happy to implement it myself.

katbyte · 2019-05-13T17:37:44Z

azuread/resource_group_member.go

+	}
+
+	_, err := client.AddMember(ctx, groupID, properties)
+	if err != nil {


minor these two lines can be merged:

if _, err := client.AddMember(ctx, groupID, properties); err != nil {

katbyte · 2019-05-13T17:38:42Z

azuread/resource_group_member.go

+		}
+
+		err = members.NextWithContext(ctx)
+		if err != nil {


These two lines could be merged

katbyte · 2019-05-13T17:39:10Z

azuread/resource_group_member.go

+	}
+
+	if memberObjectID == "" {
+		log.Printf("[DEBUG] Azure AD Group Member was not found (groupObjectId:%q / memberObjectId:%q ) - removing from state!", groupID, memberID)


Is this debug log redundant as we immediately return an error?

katbyte · 2019-05-13T17:40:12Z

website/docs/r/group_member.markdown

+
+The following arguments are supported:
+
+* `group_object_id` - (Required) The Object ID of the Azure AD Group you want to add the Member to.


Can we note that this forces a new resource?

Suggested change

* `group_object_id` - (Required) The Object ID of the Azure AD Group you want to add the Member to.

* `group_object_id` - (Required) The Object ID of the Azure AD Group you want to add the Member to. Changing this forces a new resource to be created.

katbyte · 2019-05-13T17:40:22Z

website/docs/r/group_member.markdown

+The following arguments are supported:
+
+* `group_object_id` - (Required) The Object ID of the Azure AD Group you want to add the Member to.
+* `member_object_id` - (Required) The Object ID of the Azure AD Object you want to add as a Member to the Group. Supported Object types are Users, Groups or Service Principals.


Suggested change

* `member_object_id` - (Required) The Object ID of the Azure AD Object you want to add as a Member to the Group. Supported Object types are Users, Groups or Service Principals.

* `member_object_id` - (Required) The Object ID of the Azure AD Object you want to add as a Member to the Group. Supported Object types are Users, Groups or Service Principals. Changing this forces a new resource to be created.

katbyte · 2019-05-13T17:41:22Z

azuread/resource_group_member.go

+	memberID := id[1]
+
+	resp, err := client.RemoveMember(ctx, groupID, memberID)
+


Suggested change

landro · 2019-05-22T08:12:25Z

Any idea about ETA for this PR, @tiwood ? Can I help in any way?

katbyte · 2019-05-23T14:40:45Z

@landro, looks like PR comments still need to be addressed as well as adding the members property to the group resource

evenh · 2019-06-05T06:42:59Z

@katbyte Would a new PR (based on this PR) be acceptable (with fixes)?

katbyte · 2019-06-06T15:56:53Z

@evenh, yep given this has sat for a month i think its reasonable to open a new one.

landro · 2019-06-06T16:04:10Z

Ok Great. You can expect a pull request from @evenh tomorrow.

…

6. jun. 2019 kl. 17:56 skrev kt ***@***.***>: @evenh, yep given this has sat for a month i think its reasonable to open a new one. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

katbyte · 2019-06-06T16:37:59Z

~~Looks like i had some fixes on a local branch, i'll push that now.~~ nope was for group owners

One thing also is i was going to use {group_id}/member/{object_id} to prevent conflicts with owners

tiwood · 2019-06-07T05:50:48Z

@katbyte @evenh @landro Thank you for helping, I'm currently pretty busy with customer projects and was unable to work on this in a timely matter.

As this is a much requested feature, your help is much appreciated.

katbyte · 2019-06-07T05:55:03Z

no bother @tiwood, thank you for starting them 🙂

katbyte · 2019-06-12T19:42:30Z

closing in favour of #100

continues #63 fixed 1/2 of #36

ghost · 2019-07-13T16:50:25Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

tiwood added 3 commits March 13, 2019 18:01

New resource 'azuread_group_member'

d265685

Tests for 'azuread_group_member'

7b2dae5

Documentation for new resource 'azuread_group_member'

5d07e06

ghost added documentation size/XL labels Mar 13, 2019

katbyte requested changes May 13, 2019

View reviewed changes

katbyte added feature/groups new-resource waiting-response labels May 13, 2019

ghost removed the waiting-response label May 22, 2019

katbyte added the waiting-response label May 23, 2019

ghost removed the waiting-response label Jun 5, 2019

evenh mentioned this pull request Jun 6, 2019

Resource: 'azuread_group_member' #100

Merged

katbyte closed this Jun 12, 2019

katbyte pushed a commit that referenced this pull request Jul 12, 2019

Resource: 'azuread_group_member' (#100)

e9db6a8

continues #63 fixed 1/2 of #36

hashicorp locked and limited conversation to collaborators Jul 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource 'azuread_group_member' #63

New resource 'azuread_group_member' #63

tiwood commented Mar 13, 2019

tiwood commented Mar 13, 2019

tiwood commented Apr 4, 2019

katbyte commented Apr 12, 2019

katbyte commented Apr 12, 2019

tiwood commented May 6, 2019

katbyte left a comment

katbyte May 13, 2019

katbyte May 13, 2019

katbyte May 13, 2019

katbyte May 13, 2019

katbyte May 13, 2019

katbyte May 13, 2019

landro commented May 22, 2019

katbyte commented May 23, 2019

evenh commented Jun 5, 2019 •

edited

katbyte commented Jun 6, 2019

landro commented Jun 6, 2019 via email

katbyte commented Jun 6, 2019 •

edited

tiwood commented Jun 7, 2019

katbyte commented Jun 7, 2019

katbyte commented Jun 12, 2019

ghost commented Jul 13, 2019


		The following arguments are supported:

		* `group_object_id` - (Required) The Object ID of the Azure AD Group you want to add the Member to.

	* `member_object_id` - (Required) The Object ID of the Azure AD Object you want to add as a Member to the Group. Supported Object types are Users, Groups or Service Principals.
	* `member_object_id` - (Required) The Object ID of the Azure AD Object you want to add as a Member to the Group. Supported Object types are Users, Groups or Service Principals. Changing this forces a new resource to be created.

		memberID := id[1]

		resp, err := client.RemoveMember(ctx, groupID, memberID)

New resource 'azuread_group_member' #63

New resource 'azuread_group_member' #63

Conversation

tiwood commented Mar 13, 2019

Example Usage

Argument Reference

tiwood commented Mar 13, 2019

tiwood commented Apr 4, 2019

katbyte commented Apr 12, 2019

katbyte commented Apr 12, 2019

tiwood commented May 6, 2019

katbyte left a comment

Choose a reason for hiding this comment

katbyte May 13, 2019

Choose a reason for hiding this comment

katbyte May 13, 2019

Choose a reason for hiding this comment

katbyte May 13, 2019

Choose a reason for hiding this comment

katbyte May 13, 2019

Choose a reason for hiding this comment

katbyte May 13, 2019

Choose a reason for hiding this comment

katbyte May 13, 2019

Choose a reason for hiding this comment

landro commented May 22, 2019

katbyte commented May 23, 2019

evenh commented Jun 5, 2019 • edited

katbyte commented Jun 6, 2019

landro commented Jun 6, 2019 via email

katbyte commented Jun 6, 2019 • edited

tiwood commented Jun 7, 2019

katbyte commented Jun 7, 2019

katbyte commented Jun 12, 2019

ghost commented Jul 13, 2019

evenh commented Jun 5, 2019 •

edited

katbyte commented Jun 6, 2019 •

edited