azurerm_log_analytics_workspace_linked_service: fix casing issues

[katbyte]

fixes #2593

[katbyte]

tests:

[18:14:45] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸log-analytics/uppercase$ testazure TestAccAzureRMLogAnalyticsWorkspaceLinkedService
==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMLogAnalyticsWorkspaceLinkedService -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic
=== PAUSE TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete
=== PAUSE TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete
=== CONT  TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic
=== CONT  TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic (100.80s)
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete (101.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	102.184s

[tombuildsstuff]

otherwise LGTM 👍

[tombuildsstuff]

I think we should be able to remove this, and instead update the validation to require lower-case here?

[tombuildsstuff]

(we should also raise a bug about this API being broken, if there's not one already)

[katbyte]

That would potentially break existing terraform and not match the portal. Workspace's are allowed to have capitalized characters and that resource works just fine with them (see updated tests)

[katbyte]

issue opened

[katbyte]

tests:

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMLogAnalytics -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic
=== PAUSE TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete
=== PAUSE TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_basic
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_basic
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_complete
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_complete
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_basic
=== CONT  TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== CONT  TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_complete
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_basic (89.13s)
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_complete (89.38s)
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_basic (93.87s)
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring (95.03s)
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_complete (159.70s)
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicSecurity (160.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	162.547s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!