Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: correctly read reply URL's from SDK #2729

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 22, 2019

backport of azuread#21

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

Tests pass:

screenshot 2019-01-22 at 14 02 08

@tombuildsstuff tombuildsstuff merged commit 8b29902 into master Jan 22, 2019
@tombuildsstuff tombuildsstuff deleted the azuread/app-replyurls branch January 22, 2019 14:02
tombuildsstuff added a commit that referenced this pull request Jan 22, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants