r/virtual_machine: switching over to the new Storage SDK

[tombuildsstuff]

This PR contains a few things related to the new Storage SDK switch:

• Retrieving the OS/Data Disks from Azure, rather than trying to parse the config. This ensures that all Disks attached to the Virtual Machine should be deleted at deletion time should the user be opted into it.
• Switches to deleting the OS Disk using the new Storage SDK
• Switches to deleting the Data Disks using the new Storage SDK

I believe this should fix #102

[tombuildsstuff]

Ignoring some failing tests ('plan' is resolved, one's handled by #3842 and the others are Quota issues) - the tests pass:

[katbyte]

LGTM 👍

[ghost]

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

[jomeier]

Hi,

what must be done to solve this TODO? :

// TODO: use a custom importer so that `delete_os_disk_on_termination` and 
`delete_data_disks_on_termination` are set

In our use case we must import a VM into the Terraform state by 'terraform import ... ...' and this field is imported with NULL.

Greetz,

Josef

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!