Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: azurerm_virtual_network_peering prevent nil object from being read #4180

Merged
merged 3 commits into from
Aug 29, 2019
Merged

Bug Fix: azurerm_virtual_network_peering prevent nil object from being read #4180

merged 3 commits into from
Aug 29, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Aug 28, 2019 •
edited

Addressing #4169

--- PASS: TestAccAzureRMVirtualNetworkPeering_disappears (128.76s)
--- PASS: TestAccAzureRMVirtualNetworkPeering_basic (202.19s)
--- FAIL: TestAccAzureRMVirtualNetworkPeering_requiresImport (240.15s)
--- PASS: TestAccAzureRMVirtualNetworkPeering_update (243.41s)

@ghost ghost added the size/XS label Aug 28, 2019
@mbfrahry mbfrahry requested a review from a team August 28, 2019 16:43
@mbfrahry mbfrahry added this to the v1.34.0 milestone Aug 28, 2019
katbyte
katbyte approved these changes Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tombuildsstuff
tombuildsstuff approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

azurerm/resource_arm_virtual_network_peering.go Outdated Show resolved Hide resolved
@ghost ghost added documentation size/L and removed size/XS labels Aug 28, 2019
@ghost ghost added size/XS and removed size/L labels Aug 28, 2019
mbfrahry and others added 2 commits August 28, 2019 16:52
@mbfrahry @tombuildsstuff
Update azurerm/resource_arm_virtual_network_peering.go
ffb8dfa 
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@mbfrahry
Address review
c942641
tombuildsstuff
tombuildsstuff approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbfrahry mbfrahry merged commit 25fd3bd into master Aug 29, 2019
@mbfrahry mbfrahry deleted the b-vnet-peering-crash branch August 29, 2019 07:46
@mbfrahry mbfrahry mentioned this pull request Aug 29, 2019
Closed
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
crash documentation service/virtual-networks size/XS
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbfrahry @tombuildsstuff @katbyte