Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_group: make storage_account_key field in volume block sensitive #4201

Merged
merged 1 commit into from
Aug 30, 2019
Merged

azurerm_container_group: make storage_account_key field in volume block sensitive #4201

merged 1 commit into from
Aug 30, 2019

Conversation

joakimhellum
Copy link

This makes the storage_account_key field in the volume block (within container) in the azurerm_container_group resource sensitive.

@ghost ghost added the size/XS label Aug 30, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @joakimhellum-in, LGTM 👍

@katbyte katbyte added this to the v1.34.0 milestone Aug 30, 2019
@katbyte katbyte merged commit 459e637 into hashicorp:master Aug 30, 2019
katbyte added a commit that referenced this pull request Aug 30, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants