Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/eventhub_namespace: deprecating kafka_enabled since this is now managed by Azure #4743

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Oct 29, 2019

The field kafka_enabled is now automatically configured by Azure depending on the
sku being used - where it's Disabled for a Basic sku but Enabled for a Standard
sku - as such this field is no longer user configurable and will be removed in 2.0

Fixes #4598

…anaged by Azure

The field `kafka_enabled` is now automatically configured by Azure depending on the
sku being used - where it's Disabled for a `Basic` sku but Enabled for a `Standard`
sku - as such this is no longer user configurable and will be removed in 2.0
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-10-29 at 07 26 17

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 3fbd00e into master Oct 29, 2019
@katbyte katbyte deleted the b/eventhub-namespace-kafka branch October 29, 2019 14:13
katbyte added a commit that referenced this pull request Oct 29, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Hub Namespace keeps wanting to update kafka_enabled
2 participants