Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app - support for min_tls_version #5074

Merged
merged 2 commits into from
Dec 12, 2019
Merged

azurerm_function_app - support for min_tls_version #5074

merged 2 commits into from
Dec 12, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Dec 5, 2019

Fixes: #3740

Adds the min_tls_version option to the azurerm_function_app resource.

=== RUN   TestAccAzureRMFunctionApp_minTlsVersion
=== PAUSE TestAccAzureRMFunctionApp_minTlsVersion
=== CONT  TestAccAzureRMFunctionApp_minTlsVersion
--- PASS: TestAccAzureRMFunctionApp_minTlsVersion (222.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       222.803s

@tombuildsstuff tombuildsstuff added this to the v1.39.0 milestone Dec 5, 2019
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aqche

Thanks for this PR - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff
Copy link
Member

Tests look good:

Screenshot 2019-12-12 at 10 55 02

@tombuildsstuff tombuildsstuff merged commit 054cf78 into hashicorp:master Dec 12, 2019
tombuildsstuff added a commit that referenced this pull request Dec 12, 2019
@aqche aqche deleted the support_function_app_min_tls_version branch December 13, 2019 02:08
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 13, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Function App - adding support for min TLS version and HTTPS Only
3 participants