virtual_machine_scale_set datasource - support network_interfaces #10585

shurikk · 2021-02-15T02:21:09Z

Knowing scale set network_profile is important when creating load balancers as a separate process/state because the scale set and the load balancer must be on the same virtual network.

katbyte

Thanks for the pr @shurikk - could we update the docs to reflect this new property? thanks

shurikk · 2021-04-15T04:30:49Z

yes, will do, was planning to but got distracted

katbyte

Thanks @shurikk - overall this looks good but instead of referring to the schema in another resource could we pull that out? I think the new windows|linux virtual resources already have done that so you should be able to use "network_interface": VirtualMachineScaleSetNetworkInterfaceSchema(),

katbyte · 2021-04-26T18:44:35Z

azurerm/internal/services/compute/virtual_machine_scale_set_data_source.go

+	return &schema.Schema{
+		Type:     schema.TypeSet,
+		Computed: true,
+		Elem:     resourceVirtualMachineScaleSet().Schema["network_profile"].Elem,


We should pull that out into a shared schema function instead of doing this

azurerm/internal/services/compute/virtual_machine_scale_set_data_source.go

…ta_source.go Co-authored-by: kt <kt@katbyte.me>

shurikk · 2021-04-26T21:48:56Z

@katbyte just to be on the same page, we want this change to be aligned with linux_virtual_machine_scale_set and windows_virtual_machine_scale_set rather than virtual_machine_scale_set? If yes, then the docs should be updated as well.

perhaps new data sources should be introduced rather than adding new properties to the virtual_machine_scale_set?

katbyte · 2021-04-27T00:55:19Z

@shurikk - correct, those are the new resources that will replace the old virtual_machine_scale_set. they share the VirtualMachineScaleSetNetworkInterfaceSchema so it should be fine to add this to the virtual_machine_scale_set data source

shurikk · 2021-04-27T02:01:38Z

@katbyte updated, still need schemaNetworkInterfaceForDataSource to set Computed: true, cannot use VirtualMachineScaleSetNetworkInterfaceSchema() directly without that. Perhaps there is a better way?

e.g.

data azurerm_virtual_machine_scale_set vmss {
  name                = "test-vmss"
  resource_group_name = "test-group"
}

output test {
  value = data.azurerm_virtual_machine_scale_set.vmss
}

results in

Error: "network_interface": required field is not set                                                                                                         
                                                                                                                                                              
  on main.tf line 18, in data "azurerm_virtual_machine_scale_set" "vmss":                                                                                     
  18: data azurerm_virtual_machine_scale_set vmss {

katbyte · 2021-04-27T02:39:45Z

oh right 🤦‍♀️🤦‍♀️ sorry i totally blanked on this, this is a datasource so we need to have everything be computed, which means copying that function's schema and changing everything to be computed - however you should beable to reuse the flatten function

shurikk · 2021-04-27T16:19:04Z

@katbyte how should we proceed from here? I've updated docs and the code to be aligned with linux and windows scale sets.

…-to-virtual-machine-scale-set-data

shurikk · 2021-04-27T17:54:24Z

config

data azurerm_virtual_machine_scale_set vmss {
  name                = "test-vmss"
  resource_group_name = "test"
}

output x { 
  value = data.azurerm_virtual_machine_scale_set.vmss
}

terraform output

x = {
  "id" = "/subscriptions/.../.../Microsoft.Compute/virtualMachineScaleSets/test-vmss"
  "identity" = tolist([])
  "location" = tostring(null)
  "name" = "test-vmss"
  "network_interface" = tolist([
    {
      "dns_servers" = tolist([])
      "enable_accelerated_networking" = true
      "enable_ip_forwarding" = false
      "ip_configuration" = tolist([
        {
          "application_gateway_backend_address_pool_ids" = toset([])
          "application_security_group_ids" = toset([])
          "load_balancer_backend_address_pool_ids" = toset([
            "/subscriptions/.../.../backendAddressPools/test-lb",
          ])
          "load_balancer_inbound_nat_rules_ids" = toset([])
          "name" = "test-vmss"
          "primary" = true
          "public_ip_address" = tolist([])
          "subnet_id" = "/subscriptions/.../.../subnets/subnet12345"
          "version" = "IPv4"
        },
      ])
      "name" = "test-vmss"
      "network_security_group_id" = ""
      "primary" = true
    },
  ])
  "resource_group_name" = "test"
  "timeouts" = null /* object */
}

katbyte · 2021-04-27T18:08:14Z

@shurikk - i hope you don't mind but I just pushed the changes required to get this merged, i'll have someone else review it and get it into this weeks release 🙂

shurikk · 2021-04-27T19:08:59Z

@shurikk - i hope you don't mind but I just pushed the changes required to get this merged, i'll have someone else review it and get it into this weeks release 🙂

thanks, works, it's not super urgent. also noticed some doc updates, still work in progress?

WodansSon

@katbyte, thank you for this PR... I left one super minor comment and there are a few lint errors. Other than that this LGTM! 🚀

azurerm/internal/services/compute/virtual_machine_scale_set_data_source.go

…ta_source.go Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com>

manicminer

LGTM! 🚀

…shicorp#10585) Co-authored-by: kt <kt@katbyte.me> Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com> Co-authored-by: Alexander Kabanov <akabanov@linkedin.com>

ghost · 2021-04-30T02:21:04Z

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

magodo

Shall we change the schemas above to be Computed: true?

magodo · 2021-05-14T07:30:38Z

azurerm/internal/services/compute/virtual_machine_scale_set.go

+func virtualMachineScaleSetIPConfigurationSchemaForDataSource() *schema.Schema {
+	return &schema.Schema{
+		Type:     schema.TypeList,
+		Required: true,


Should we change this to Computed: true?

magodo · 2021-05-14T07:30:42Z

azurerm/internal/services/compute/virtual_machine_scale_set.go

+func virtualMachineScaleSetPublicIPAddressSchemaForDataSource() *schema.Schema {
+	return &schema.Schema{
+		Type:     schema.TypeList,
+		Optional: true,


Should we change this to Computed: true?

github-actions · 2021-06-14T02:11:19Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

add network_profile to virtual_machine_scale_set data

2d5544e

ghost added the size/XS label Feb 15, 2021

shurikk marked this pull request as draft February 15, 2021 02:25

katbyte added enhancement service/vmss Virtual Machine Scale Sets labels Apr 6, 2021

katbyte requested changes Apr 15, 2021

View reviewed changes

update docs

4cde852

ghost added size/S documentation and removed size/XS labels Apr 17, 2021

shurikk marked this pull request as ready for review April 17, 2021 22:19

katbyte requested changes Apr 26, 2021

View reviewed changes

katbyte reviewed Apr 26, 2021

View reviewed changes

azurerm/internal/services/compute/virtual_machine_scale_set_data_source.go Outdated Show resolved Hide resolved

katbyte added the waiting-response label Apr 26, 2021

katbyte added this to the v2.57.0 milestone Apr 26, 2021

katbyte mentioned this pull request Apr 26, 2021

New data source - azurerm_virtual_machine_scale_set_network_interfaces #6752

Closed

Update azurerm/internal/services/compute/virtual_machine_scale_set_da…

4e826ae

…ta_source.go Co-authored-by: kt <kt@katbyte.me>

ghost removed the waiting-response label Apr 26, 2021

address comments

6909b40

katbyte added the waiting-response label Apr 27, 2021

ghost removed the waiting-response label Apr 27, 2021

Merge remote-tracking branch 'origin/master' into add-network-profile…

2451218

…-to-virtual-machine-scale-set-data

update to use new schema

30aade3

ghost added size/L and removed size/S labels Apr 27, 2021

cleanup

717612c

katbyte changed the title ~~add network_profile to virtual_machine_scale_set data~~ virtual_machine_scale_set datasource - support network_interfaces Apr 27, 2021

katbyte added 2 commits April 27, 2021 14:42

dox fixes

7eeb707

fix schema

df42f02

WodansSon approved these changes Apr 27, 2021

View reviewed changes

azurerm/internal/services/compute/virtual_machine_scale_set_data_source.go Outdated Show resolved Hide resolved

Update azurerm/internal/services/compute/virtual_machine_scale_set_da…

1304179

…ta_source.go Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com>

manicminer approved these changes Apr 27, 2021

View reviewed changes

katbyte added 2 commits April 27, 2021 19:47

required -> computed

6d0896c

remove set specific code

4e68d70

katbyte merged commit d23845d into hashicorp:master Apr 28, 2021

katbyte added a commit that referenced this pull request Apr 28, 2021

CHANGELOG.md for #10585

419327c

alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this pull request Apr 29, 2021

CHANGELOG.md for hashicorp#10585

bbbeb9a

shurikk deleted the add-network-profile-to-virtual-machine-scale-set-data branch April 30, 2021 14:41

magodo reviewed May 14, 2021

View reviewed changes

magodo mentioned this pull request May 14, 2021

azurerm_virtual_machine_scale_set DS - adjust the schemas to be Computed #11712

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

virtual_machine_scale_set datasource - support network_interfaces #10585

virtual_machine_scale_set datasource - support network_interfaces #10585

shurikk commented Feb 15, 2021

katbyte left a comment

shurikk commented Apr 15, 2021

katbyte left a comment

katbyte Apr 26, 2021

shurikk commented Apr 26, 2021 •

edited

Loading

katbyte commented Apr 27, 2021

shurikk commented Apr 27, 2021 •

edited

Loading

katbyte commented Apr 27, 2021 •

edited

Loading

shurikk commented Apr 27, 2021

shurikk commented Apr 27, 2021

katbyte commented Apr 27, 2021

shurikk commented Apr 27, 2021

WodansSon left a comment

manicminer left a comment

ghost commented Apr 30, 2021

magodo left a comment

magodo May 14, 2021

magodo May 14, 2021

github-actions bot commented Jun 14, 2021

virtual_machine_scale_set datasource - support network_interfaces #10585

virtual_machine_scale_set datasource - support network_interfaces #10585

Conversation

shurikk commented Feb 15, 2021

katbyte left a comment

Choose a reason for hiding this comment

shurikk commented Apr 15, 2021

katbyte left a comment

Choose a reason for hiding this comment

katbyte Apr 26, 2021

Choose a reason for hiding this comment

shurikk commented Apr 26, 2021 • edited Loading

katbyte commented Apr 27, 2021

shurikk commented Apr 27, 2021 • edited Loading

katbyte commented Apr 27, 2021 • edited Loading

shurikk commented Apr 27, 2021

shurikk commented Apr 27, 2021

katbyte commented Apr 27, 2021

shurikk commented Apr 27, 2021

WodansSon left a comment

Choose a reason for hiding this comment

manicminer left a comment

Choose a reason for hiding this comment

ghost commented Apr 30, 2021

magodo left a comment

Choose a reason for hiding this comment

magodo May 14, 2021

Choose a reason for hiding this comment

magodo May 14, 2021

Choose a reason for hiding this comment

github-actions bot commented Jun 14, 2021

shurikk commented Apr 26, 2021 •

edited

Loading

shurikk commented Apr 27, 2021 •

edited

Loading

katbyte commented Apr 27, 2021 •

edited

Loading