Add test and sample for AKS with route table. #2286
Conversation
tombuildsstuff
added
documentation
enhancement
and removed
documentation
testing
labels
metacpp
force-pushed
the
aks_doc_update
branch
from
2c04820
to
ca17045
Compare
There was a problem hiding this comment.
hi @metacpp
Thanks for this PR - apologies for the delayed review here.
This PR generally looks ok - I've left a few comments inline since I believe we should be able to combine some of the tests. I've been taking a look into #1820 today which has involved some changes which will conflict with this - rather than trying to reconcile those I'm going to pull these changes into #1820 and make the suggested fixes, I hope you don't mind!
Thanks!
|
Closing as these changes have been pulled into #1820 |
* Adding support for AzureAD auth to AKS via RBAC * formatting * formatting * Adding documentation updates * Fixing issues with aadProfile server_app_secret always causing a new cluster * Refactoring code to avoid repetition in some areas. Documentation updates. * minor updates to testing section of main documentation index * docs: client_id -> client_app_id * fixing one more misnamed var in the docs * AKS: switching RBAC to be an independent block * Rewriting the documentation to be clearer (ala VM's) * AKS: refactoring * AKS: adding additional context to the errors * updating a todo * Data Source: refactoring * Data Source: continued re-ordering/removing the existing structure * d/AKS: adding the `role_based_access_control` block * AKS: support for up to 100 agents * Updating the versions of kubernetes being used * Documentation: moving the AKS Examples into their own folder * removing the older aks examples * Updating to include the changes from #2286 * re-ordering/updating the errors * removing the unused env variables * fixing the linting * fixing broken tests * fixes from code review
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
W/o specifying the route table and associate it with subnet, AKS will try to create a new route table instead and not associate it w/ subnet.
Before AKS team apply the fix, we'd like to update the test to cover customized route table scenario and encourage user to specify it instead of using default one, which is not working for now.