New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_lb - support for the private_ip_address_version
property
#5590
azurerm_lb - support for the private_ip_address_version
property
#5590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @smarterclayton, these changes look good but we're seeing a crash while I testing.
fb3f393
to
a2d4034
Compare
Azure allows load balancers to have an allocated private ip address version in their frontend configuration to select between IPv4 and IPv6, like NICs. Make setting the version on load balancers consistent with NICs.
a2d4034
to
2bac2c7
Compare
Updated, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @smarterclayton,
This looks good aside from we need at add it to the complete
test and update the documentation.
private_ip_address_version
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smarterclayton,
I hope you don't mind but i pushed the required changes to merge this. LGTM now 👍
This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.1.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Azure allows load balancers to have an allocated private ip address
version in their frontend configuration to select between IPv4 and
IPv6, like NICs. Make setting the version on load balancers consistent
with NICs.