Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ip firewall connection tracking #260

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Ip firewall connection tracking #260

merged 6 commits into from
Sep 22, 2023

Conversation

jlpedrosa
Copy link
Contributor

Resource to configure Ip connection tracking.

@jlpedrosa jlpedrosa requested a review from a team as a code owner September 20, 2023 19:41
@jlpedrosa
Copy link
Contributor Author

I see CI is failing, it seems one of the properties is not available in older versions. I see two routes:

  1. Eliminate the options until you decide to "unsupport" older versions
  2. Create a dynamic validation based on the version of the OS running.

Let me know what route you want me to take (or other?) and/or any advice if you want route 2.

@vaerh
Copy link
Collaborator

vaerh commented Sep 20, 2023

This is a long-standing problem. Solution in resource_snmp_test.go

@jlpedrosa jlpedrosa force-pushed the ip_firewall_connection_tracking branch from e6ab2e3 to b0c92e5 Compare September 20, 2023 21:43
vaerh
vaerh reviewed Sep 21, 2023
View reviewed changes
routeros/provider_schema_helpers.go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to do some checks regarding this code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! One of the reasons I did this is because the documentation for that part of the system was very flaky, some fields were not even in the documentation, missing descriptions. I felt it was sanier not to override things.
Personally I think is a sane behaviour for a most of the fields. It also prevents drifting for values that are not user provided.

@vaerh vaerh merged commit 9d39bf8 into terraform-routeros:main Sep 22, 2023
3 checks passed
@vaerh
Copy link
Collaborator

vaerh commented Sep 22, 2023

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaerh vaerh vaerh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlpedrosa @vaerh