Add single-line comments #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lex whitespace and line endings as SyntaxTrivia.
The submission is not complete if there are no members in the CompilationUnitSyntax. This triggers if there is whitespace in the submission.
If you type comments into the Repl they get associated with the EndOfFileToken. To display them the Repl needs access to the EndOfFileToken. Adds some color as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on your answer on #79 I thought i would give it a try, at least single-line comments for now.
This PR implements single-line comments which are saved as
SingeLineCommentTrivain theSyntaxTokens.WhitespaceTokengot changed toWhitespaceTriviaandEndOfLineTriviaas well.I choose
//for the syntax, because I was interested how this interacts with theSlashToken.Multiline comments themself are not that hard, but it needs some changes to the way the REPL handles syntax coloring (each line is parsed separately). I have tried something, but that's not yet ready for a pull request. 😅
Thanks a lot for this series. 👍
PS: No worries if you don't merge this, I know it might not fit with your roadmap.