Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tmc): disable log syncing for non-utf8 output. #1192

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Oct 20, 2023

Reason for This Change

We should not allow sync of logs containing binary or non-supported encoding schemes.

Description of Changes

Each detected line is validated for utf8 and sync is disabled for the command if not valid.

Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
@i4ki i4ki requested a review from a team as a code owner October 20, 2023 17:20
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit 41dccb2
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/6532b6e14d14f800083d33b4

@github-actions
Copy link

metric: time/op
CloudReadLines-2: old 1.90ms ± 9%: new 1.95ms ± 8%: delta: 0.00%
CloudReadLine-2: old 11.8ms ± 2%: new 11.5ms ± 3%: delta: -2.79%
ListFiles-2: old 183µs ± 5%: new 188µs ± 4%: delta: 2.66%
Generate-2: old 4.64s ± 3%: new 4.60s ± 1%: delta: 0.00%
GenerateRegex-2: old 2.96s ± 4%: new 2.88s ± 2%: delta: -2.92%
TokensForExpressionComplex-2: old 2.31ms ± 4%: new 2.24ms ± 4%: delta: -2.92%
TokensForExpressionPlainStringNoNewline-2: old 1.69µs ± 2%: new 1.68µs ± 3%: delta: -1.04%
TokensForExpressionStringWith100Newlines-2: old 56.0µs ± 3%: new 54.4µs ± 3%: delta: -2.76%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 2.67ms ± 2%: new 2.62ms ± 3%: delta: -2.09%
TokensForExpression-2: old 2.31ms ± 2%: new 2.23ms ± 4%: delta: -3.31%
PartialEvalComplex-2: old 757µs ± 5%: new 723µs ± 3%: delta: -4.50%
PartialEvalSmallString-2: old 6.58µs ± 3%: new 6.36µs ± 3%: delta: -3.32%
PartialEvalHugeString-2: old 3.19ms ± 2%: new 3.04ms ± 3%: delta: -4.50%
PartialEvalHugeInterpolatedString-2: old 8.82ms ± 6%: new 8.23ms ± 3%: delta: -6.67%
PartialEvalObject-2: old 38.1µs ± 4%: new 37.5µs ± 5%: delta: -1.49%
metric: alloc/op
CloudReadLines-2: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-2: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-2: old 99.4kB ± 0%: new 99.4kB ± 0%: delta: 0.00%
Generate-2: old 2.34GB ± 0%: new 2.34GB ± 0%: delta: 0.00%
GenerateRegex-2: old 953MB ± 0%: new 953MB ± 0%: delta: 0.02%
TokensForExpressionComplex-2: old 413kB ± 0%: new 413kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 402kB ± 0%: new 402kB ± 0%: delta: -0.00%
TokensForExpression-2: old 413kB ± 0%: new 413kB ± 0%: delta: -0.01%
PartialEvalComplex-2: old 353kB ± 0%: new 353kB ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-2: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-2: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-2: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-2: old 474 ± 0%: new 474 ± 0%: delta: 0.00%
Generate-2: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-2: old 18.3M ± 0%: new 18.3M ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 3.29k ± 0%: new 3.29k ± 0%: delta: 0.00%
TokensForExpression-2: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
PartialEvalComplex-2: old 2.83k ± 0%: new 2.83k ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-2: old 125 ± 0%: new 125 ± 0%: delta: 0.00%

@i4ki i4ki added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit b20cd0e Oct 24, 2023
13 checks passed
@i4ki i4ki deleted the i4k-disable-non-utf8-log-sync branch October 24, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants