Skip to content

Commit

Permalink
Removing the non-Python term class method (#1617)
Browse files Browse the repository at this point in the history
  • Loading branch information
john-science committed Jan 25, 2024
1 parent 161bc61 commit 0685841
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion armi/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ def __enforceLimitations(self):
assert (
len(self.__class__.defineSettings()) == 0
), "UserPlugins cannot define new Settings, consider using an ArmiPlugin."
# NOTE: These are the class methods that we are staunchly _not_ allowing people
# NOTE: These are the methods that we are staunchly _not_ allowing people
# to change in this class. If you need these, please use a regular ArmiPlugin.
self.defineParameterRenames = lambda: {}
self.defineSettings = lambda: []
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/blueprints/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ def migrate(cls, inp: typing.TextIO):

@classmethod
def load(cls, stream, roundTrip=False):
"""This class method is a wrapper around the `yamlize.Object.load()` method.
"""This method is a wrapper around the `yamlize.Object.load()` method.
The reason for the wrapper is to allow us to default to `Cloader`. Essentially,
the `CLoader` class is 10x faster, but doesn't allow for "round trip" (read-
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/blueprints/blockBlueprint.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def _getMaterialModsFromBlockChildren(self, c: Composite) -> Set[str]:
materialParentClass.applyInputParams
).parameters.keys()
)
# self is a parameter to class methods, so it gets picked up here
# self is a parameter to methods, so it gets picked up here
# but that's obviously not a real material modifier
perChildModifiers.discard("self")
return perChildModifiers
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/blueprints/reactorBlueprint.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def construct(self, cs, bp, reactor, geom=None, loadAssems=True):
loadAssems : bool, optional
whether to fill reactor with assemblies, as defined in blueprints, or not. Is False in
:py:class:`UniformMeshGeometryConverter <armi.reactor.converters.uniformMesh.UniformMeshGeometryConverter>`
within the initNewReactor() class method.
within the initNewReactor() method.
Raises
------
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/composites.py
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ def getParameterCollection(cls):
``paramCollectionType`` is not a top-level object and therefore cannot be
trivially pickled. Since we know that by the time we want to make any instances
of/unpickle a given ``ArmiObject``, such a class attribute will have been
created and associated. So, we use this top-level class method to dig
created and associated. So, we use this top-level method to dig
dynamically down to the underlying parameter collection type.
.. impl:: Composites (and all ARMI objects) have parameter collections.
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/parameters/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class instance to have a ``__dict__``. This saves memory when there are many
* - Parameters are just fancy properties with meta data.
- Implementing the descriptor interface on a :py:class:`Parameter` removes the
need to construct a :py:class:`Parameter` without a name, then come back through
with the ``applyParameters()`` class method to apply the
with the ``applyParameters()`` method to apply the
:py:class:`Parameter` as a descriptor.
.. _thefreedictionary: http://www.thefreedictionary.com/parameter
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/parameters/parameterDefinitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,6 @@ def defParam(


# Container for all parameter definition collections that have been bound to an
# ArmiObject or subclass. These are added from the applyParameters() class method on
# ArmiObject or subclass. These are added from the applyParameters() method on
# the ParameterCollection class.
ALL_DEFINITIONS = ParameterDefinitionCollection()
2 changes: 1 addition & 1 deletion armi/settings/setting.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class Setting:
:implements: R_ARMI_SETTINGS_DEFAULTS
Setting objects hold all associated information of a setting in ARMI and should
typically be accessed through the Settings class methods rather than directly.
typically be accessed through the Settings methods rather than directly.
Settings require a mandatory default value.
Setting subclasses can implement custom ``load`` and ``dump`` methods that can
Expand Down

0 comments on commit 0685841

Please sign in to comment.