Pointing the Component.density method at 3D material density (#1149)

terrapower · Feb 3, 2023 · 2a9cd5c · 2a9cd5c
1 parent 5cfddf6
commit 2a9cd5c
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/armi/materials/uraniumOxide.py b/armi/materials/uraniumOxide.py
@@ -55,7 +55,7 @@ class UraniumOxide(material.FuelMaterial, material.SimpleSolid):
     propertyUnits = {"heat capacity": "J/mol-K"}
 
     propertyValidTemperature = {
-        "density": ((300, 3100), "K"),
+        "density3": ((300, 3100), "K"),
         "heat capacity": ((298.15, 3120), "K"),
         "linear expansion": ((273, 3120), "K"),
         "linear expansion percent": ((273, __meltingPoint), "K"),
@@ -166,7 +166,7 @@ def density3(self, Tk: float = None, Tc: float = None) -> float:
         Polynomial line fit to data from [#ornltm2000]_ on page 11.
         """
         Tk = getTk(Tc, Tk)
-        self.checkPropertyTempRange("density", Tk)
+        self.checkPropertyTempRange("density3", Tk)
 
         return (-1.01147e-7 * Tk ** 2 - 1.29933e-4 * Tk + 1.09805e1) * self.getTD()
 

diff --git a/armi/reactor/components/component.py b/armi/reactor/components/component.py
@@ -1165,7 +1165,7 @@ def density(self):
 
         if not density:
             # possible that there are no nuclides in this component yet. In that case, defer to Material.
-            density = self.material.density(Tc=self.temperatureInC)
+            density = self.material.density3(Tc=self.temperatureInC)
 
         return density
 

diff --git a/armi/reactor/tests/test_components.py b/armi/reactor/tests/test_components.py
@@ -20,6 +20,7 @@
 import math
 import unittest
 
+from armi.materials.material import Material
 from armi.reactor import components
 from armi.reactor.components import (
     Component,
@@ -326,6 +327,31 @@ def test_densityConsistent(self):
             c.getArea() * c.parent.getHeight() * c.density(), self.component.getMass()
         )
 
+    def test_density3D(self):
+        """Testing the Component density gets the correct 3D material density."""
+
+        class StrangeMaterial(Material):
+            """material designed to make the test easier to understand"""
+
+            def density(self, Tk=None, Tc=None):
+                return 1.0
+
+            def density3(self, Tk=None, Tc=None):
+                return 3.0
+
+        c = Sphere(
+            name="strangeBall",
+            material=StrangeMaterial(),
+            Tinput=200,
+            Thot=500,
+            od=1,
+            id=0,
+            mult=1,
+        )
+
+        # we expect to see the 3D material density here
+        self.assertEqual(c.density(), 3.0)
+
 
 class TestDerivedShape(TestShapedComponent):
     componentCls = DerivedShape

diff --git a/doc/release/0.2.rst b/doc/release/0.2.rst
@@ -32,6 +32,7 @@ What's new in ARMI
 #. Bug fix for Magnessium density curve. (`PR#1126 https://github.com/terrapower/armi/pull/1126`_)
 #. Bug fix for Potassium density curve. (`PR#1128 https://github.com/terrapower/armi/pull/1128`_)
 #. Bug fix for Concrete density curve. (`PR#1131 https://github.com/terrapower/armi/pull/1131`_)
+#. Bug fix for Component.density. (`PR#1149 https://github.com/terrapower/armi/pull/1149`_)
 #. Calculate block kgHM and kgFis on core loading and after shuffling. (`PR#1136 https://github.com/terrapower/armi/pull/1136`_)
 
 Bug fixes