Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointing the Component.density method at 3D material density #1149

Merged
merged 2 commits into from Feb 3, 2023

Conversation

john-science
Copy link
Member

Description

Presumably by accident, in the past the Component.density() method pointed at the 2D/linear expansion-only/pseudodensity, instead of the usual physical density of materials. This PR corrects that issue.

@opotowsky
NOTE: In testing, however, I found no materials in ARMI that explicitly defined separate pseduodensity() and density() method. So, using existing materials I could make a unit test that would fail after the change. But the moment I mocked up a material with clearly different density and pseudodensity, the test immediately failed.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added bug Something is wrong: Highest Priority cleanup Code/comment cleanup: Low Priority labels Feb 3, 2023
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, fascinating that this didn't break for any of the materials. Seems like...luck?

Anyway, this turned out to be a lot simpler than I thought!

"density": ((300, 3100), "K"),
"density3": ((300, 3100), "K"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only material you found that needed this update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I randomly happened across this one.

Perhaps we could look through all the materials for similar mis-namings.

@opotowsky
Copy link
Member

This is fine to merge @john-science

@john-science john-science merged commit 2a9cd5c into main Feb 3, 2023
@john-science john-science deleted the component_density branch February 3, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants