Pointing the Component.density method at 3D material density #1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presumably by accident, in the past the
Component.density()
method pointed at the 2D/linear expansion-only/pseudodensity, instead of the usual physical density of materials. This PR corrects that issue.@opotowsky
NOTE: In testing, however, I found no materials in ARMI that explicitly defined separate
pseduodensity()
anddensity()
method. So, using existing materials I could make a unit test that would fail after the change. But the moment I mocked up a material with clearly differentdensity
andpseudodensity
, the test immediately failed.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.