Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component density does not exactly agree with 3D density #820

Closed
onufer opened this issue Aug 5, 2022 · 2 comments · Fixed by #860
Closed

Component density does not exactly agree with 3D density #820

onufer opened this issue Aug 5, 2022 · 2 comments · Fixed by #860

Comments

@onufer
Copy link
Member

onufer commented Aug 5, 2022

#818 created a test comparing component density to material 3D density, and the differences are larger than expected (but still somewhat small, on the order of 0.001 g/cc).
@onufer onufer mentioned this issue Aug 5, 2022
Merged
7 tasks
@john-science
Copy link
Member

@onufer Is this different than #819 ?

@albeanth albeanth mentioned this issue Aug 5, 2022
Closed
@onufer
Copy link
Member Author

onufer commented Aug 5, 2022

@john-science yes. See the 2 comments in the unit tests i created. i call them out sepeartly

@onufer onufer mentioned this issue Aug 24, 2022
Merged
7 tasks
onufer added a commit that referenced this issue Aug 25, 2022
@onufer
resove #820
dcb08df
@opotowsky opotowsky linked a pull request Aug 25, 2022 that will close this issue
Fixing Component density to agree with 3D density #860
Merged
7 tasks
@onufer onufer mentioned this issue Aug 25, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Component density to agree with 3D density terrapower/armi
2 participants
@john-science @onufer