Fixing Component density to agree with 3D density #860
Conversation
|
@mgjarrett, please feel free to add comments |
| @@ -130,7 +130,7 @@ def linearExpansionPercent(self, Tk=None, Tc=None): | |||
| Tk = getTk(Tc, Tk) | |||
| self.checkPropertyTempRange("linear expansion percent", Tk) | |||
|
|
|||
| if Tk >= 291.62 and Tk < 1137: | |||
There was a problem hiding this comment.
This reverted a change that was needed to change the blueprints which also were not needed.
armi/reactor/components/component.py
Outdated
| # axialExpansionFactor = 1.0 + self.material.linearExpansionFactor( | ||
| # self.temperatureInC, self.inputTemperatureInC | ||
| # ) | ||
| self.changeNDensByFactor(1.0 / self.getThermalExpansionFactor()) |
There was a problem hiding this comment.
The else seems to only be invoked in tests, as far as I can tell. Could we just remove the initialColdMaterialExpansion argument, and then rewrite and/or remove those tests as appropriate?
There was a problem hiding this comment.
It is invoked in a TP submodule. I would also expect it could also be useful for axial expansion, although it is not used now.
There was a problem hiding this comment.
would moving the code from the if statement into applyMaterialMassFracsToNumberDensities be acceptable, and then the if statement would be eliminated but we would still have a useful hot height density reduction changer.
There was a problem hiding this comment.
If the code is used then I don't have a problem with it being here. I was just proposing removing the code if in fact it was not being used anymore.
|
wait for @ntouran to have a chance to provide feedback to merge |
john-science
changed the title
|
Taking myself off review @onufer. I think that @mgjarrett and @ntouran can have this covered. |
* Added a couple component expansion methods: adjustDensityForHeightExpansion, getHeightFactor
Description
Resolves #820 so component agrees exactly with 3D density. Removed some testing work arounds.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.