Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update B4C docstring for assumed TD frac #1117

Merged
merged 3 commits into from Jan 25, 2023
Merged

Update B4C docstring for assumed TD frac #1117

merged 3 commits into from Jan 25, 2023

Conversation

keckler
Copy link
Member

@keckler keckler commented Jan 24, 2023

Description

This closes #1116 by updating the docstring. No other changes were made.

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science
Copy link
Member

Sorry, @keckler . All your TD_frac PRs in ARMI (and elsewhere) need to have some conflicts resolved due to another Materials PR going into ARMI (and other downstream repos) this morning.

In most cases, it will be quite easy. We removed all Parameters from ARMI Materials. But we just moved all the ones that were still used to class attributes, so you can probably fix 99% of your errors by going from mat.p.thing to mat.thing.

Sorry for the hassle!

@keckler
Copy link
Member Author

keckler commented Jan 24, 2023

Done!

@john-science john-science merged commit 76a76b1 into main Jan 25, 2023
@john-science john-science deleted the keckler-patch-1 branch January 25, 2023 21:04
drewj-usnctech added a commit to drewj-usnctech/armi that referenced this pull request Jan 25, 2023
@drewj-usnctech
Merge remote-tracking branch 'terrapower/main' into drewj-usnctech/10…
83cbd1f 
…30/assembly-1d-parent-class

* terrapower/main:
  Updating B4C docstring for assumed TD frac (terrapower#1117)
  bug fix for xsGroup manager w/ coupling (terrapower#1118)
  Add neutronics category to linPow parameter (terrapower#1119)
  Refactoring Material to not subclass Composite (terrapower#1062)
  Exposing tight coupling to `OperatorSnapshots` (terrapower#1113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-science john-science john-science approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

B4C defaults to a 0.9 TD fraction
2 participants
@keckler @john-science