bug fix for xsGroup manager w/ coupling #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgjarrett
approved these changes
Jan 25, 2023
john-science
approved these changes
Jan 25, 2023
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Jan 25, 2023
…30/assembly-1d-parent-class * terrapower/main: Updating B4C docstring for assumed TD frac (terrapower#1117) bug fix for xsGroup manager w/ coupling (terrapower#1118) Add neutronics category to linPow parameter (terrapower#1119) Refactoring Material to not subclass Composite (terrapower#1062) Exposing tight coupling to `OperatorSnapshots` (terrapower#1113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix to create consistency with
latticePhysicsInterface::interactCoupledfor tight coupling.This change to the lattice physics interface was snuck into PR #1067 and limited the lattice physics interface to execute only on time node 0 of each cycle. This resulted in an inconsistency between the cross section group manager and the lattice physics interface. This PR serves to resolve this inconsistency.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.