Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving isDepletable test #1553

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Improving isDepletable test #1553

merged 1 commit into from
Dec 14, 2023

Conversation

john-science
Copy link
Member

What is the change?

Improving isDepletable test

Why is the change being made?

We are now testing if the components in these blocks are depletable, not just the blocks themselves.

Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the testing Related to tests label Dec 14, 2023
keckler
keckler approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @LMikeH

@john-science john-science merged commit 8a8ba72 into main Dec 14, 2023
21 checks passed
@john-science john-science deleted the improving_isDepletable_test branch December 14, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keckler keckler keckler approved these changes

Assignees
No one assigned
Labels
testing Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@john-science @keckler