Convert app tutorial to use submodule #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngmit
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
I think this is okay to land for now, but I don't really like the idea of having a submodule just to support building docs. We should probably move pretty aggressively towards a separate docs/website repository for this kind of stuff, while leaving the in-code docs on the main ARMI repo
This will make it more testable and also easier to play around with for users. Also added some output processing with the new VTK entry point at the end of the tutorial for good measure. Add output image Add submodule line to doc build instructions.
ntouran
force-pushed
the
app-tutorial-submod
branch
from
f2f44fd
to
089ae7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for better testing.
Also added vtk image for output processing.