Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming structuredgrid.py to camelCase #1650

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

john-science
Copy link
Member

@john-science john-science commented Feb 20, 2024

What is the change?

Changed the name of structuredgrid.py to structuredGrid.py, so it matches our camelCase naming convention.

Why is the change being made?

This PR was made to close #1608


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Feb 20, 2024
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy. I also checked a bunch of downstream repos and found nothing else that needed to be migrated.

@john-science john-science merged commit f0fe692 into main Feb 21, 2024
15 checks passed
@john-science john-science deleted the structuredgrid_camelCase branch February 21, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

structuredgrid module's name is not camelCase
2 participants