Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring 'import numpy' to 'as np' #1837

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

john-science
Copy link
Member

What is the change?

Here I have change imports of "import numpy" to "import numpy as np" everywhere by default.

@opotowsky @albeanth I know there are a lot of changes here. I am sorry about that. (And I know this will require and SCRE.)

Also, the methodology I used to fix this alphabetized some imports. I tried to undo that where I could.

Why is the change being made?

To close #1775


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Aug 27, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowza, I'm a little dizzy, and much impressed!

Nice work, and there's a few string updates I'm assuming you'll want to implement but I'm approving anyway!

armi/bookkeeping/db/database3.py Outdated Show resolved Hide resolved
armi/bookkeeping/db/database3.py Outdated Show resolved Hide resolved
armi/bookkeeping/db/database3.py Outdated Show resolved Hide resolved
Co-authored-by: Arrielle Opotowsky <arrielle.opotowsky@gmail.com>
@john-science john-science merged commit 71992d8 into terrapower:main Aug 28, 2024
11 checks passed
@john-science john-science deleted the std_np_import branch August 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to "import numpy as np"
2 participants