Ensure that Cases do not consider themselves to be their own dependency #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that self is not contained in a Case's set of dependencies. This can happen sometimes when a plugin is infering a Case dependency based on a referenced input file name. If that name maps back to the current case, it would errantly flag the current Case as its own dependency.
remove() fails if element(s) not in set
ntouran
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that self is not contained in a Case's set of
dependencies. This can happen sometimes when a plugin is infering a Case
dependency based on a referenced input file name. If that name maps back
to the current case, it would errantly flag the current Case as its own
dependency.