Removing defunct code from historyTracker Interface #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Apr 20, 2022
…efine-system-builders * terrapower/master: (24 commits) Update docstring formatting in `getPotentialParentFromSettingValue` (terrapower#627) Removing inherited docstrings from Docs (terrapower#628) Removing bare "import armi" statements (terrapower#626) Fixing assembly number issue in DB Load (terrapower#615) Making the app version more available (terrapower#624) Adding MPI tests to code coverage (terrapower#625) Removing support for XML Settings files (terrapower#612) Minor language cleanup in new standards and practices. (terrapower#610) remove extraneous `mpicov` arg from tox.ini envlist (terrapower#604) Swap flux param (terrapower#605) Fixing _fluxSwapParam for NumPy arrays (terrapower#607) Unshaped component (terrapower#600) Fixing docstring (terrapower#601) Adding options to settings report (terrapower#598) Adding coding standards and practices to Docs (terrapower#597) Removing defunct code from HistoryTrackerInterface (terrapower#594) Fix to a bug where an ARMI application could not call (terrapower#593) Tracking ARMI Requirements (terrapower#590) Remove PyYaml Dependency (terrapower#586) Filling out code coverage for entry points (terrapower#587) ...
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is in response to #583
It appears there are three entirely unused methods in the
HistoryTrackerInterface. Notably, thegetTimeIndices()method states in its docstring that it is defunct and/or broken. So, hopefully it is removable. Also, it is only used in two other places in ARMI, both in the same class:getBOCEOCTimeIndices(), andgetAssemParamHistory(). I note also that none of these three methods have any unit tests either.They seem ripe for removal, so I am testing that idea here.
Checklist