Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extraneous mpicov arg from tox.ini envlist #604

Merged
merged 1 commit into from Mar 19, 2022
Merged

Conversation

joshuavictorchen
Copy link
Member

@joshuavictorchen joshuavictorchen commented Mar 18, 2022

Description

This PR addresses #603 by removing the extraneous mpicov argument from the envlist definition in tox.ini.


Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2022

CLA assistant check
All committers have signed the CLA.

@joshuavictorchen joshuavictorchen added the cleanup Code/comment cleanup: Low Priority label Mar 18, 2022
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Don't Merge this PR right now though.

I will Merge it tonight or this weekend.

@john-science john-science merged commit 1a72dd0 into master Mar 19, 2022
@john-science john-science deleted the tox-cleanup branch March 19, 2022 14:24
drewj-usnctech added a commit to drewj-usnctech/armi that referenced this pull request Apr 20, 2022
…efine-system-builders

* terrapower/master: (24 commits)
  Update docstring formatting in `getPotentialParentFromSettingValue` (terrapower#627)
  Removing inherited docstrings from Docs (terrapower#628)
  Removing bare "import armi" statements (terrapower#626)
  Fixing assembly number issue in DB Load (terrapower#615)
  Making the app version more available (terrapower#624)
  Adding MPI tests to code coverage (terrapower#625)
  Removing support for XML Settings files (terrapower#612)
  Minor language cleanup in new standards and practices. (terrapower#610)
  remove extraneous `mpicov` arg from tox.ini envlist (terrapower#604)
  Swap flux param (terrapower#605)
  Fixing _fluxSwapParam for NumPy arrays (terrapower#607)
  Unshaped component (terrapower#600)
  Fixing docstring (terrapower#601)
  Adding options to settings report (terrapower#598)
  Adding coding standards and practices to Docs (terrapower#597)
  Removing defunct code from HistoryTrackerInterface (terrapower#594)
  Fix to a bug where an ARMI application could not call (terrapower#593)
  Tracking ARMI Requirements (terrapower#590)
  Remove PyYaml Dependency (terrapower#586)
  Filling out code coverage for entry points (terrapower#587)
  ...
albeanth pushed a commit to albeanth/armi that referenced this pull request Apr 21, 2022
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox.ini contains reference to nonexistent mpicov test environment in its envlist
3 participants