Number density bug fix #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The number densities in `applyMaterialMassFracsToNumberDensities` should be evaluated at hot temperatures to account for radial expansion of the components.
- instead of completely recalculating the number densities calculated by setNDensFromMassFracsAtTempInC, this now just scales the number densities accordingly. is an efficiency and clarity improvement
jakehader
requested changes
Aug 2, 2022
jakehader
approved these changes
Aug 3, 2022
7 tasks
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
PR terrapower#657 introduced a bug into how number densities are initialized for a component. The bug: When `detailedAxialExpansion: True`, number densities were being initialized with input temperatures. This is incorrect behavior as number densities should be initialized with hot temperatures to account for radial expansion of components. Otherwise, number densities are never adjusted for radial expansion and masses are incorrect. This PR fixes this by initializing the number densities with hot temperatures. Accounting for axial expansion via inputHeightsConsideredHot is then accounted for in adjustNDensForHotHeight. In addition to this fix, I've changed method names and improved docstrings in the interest clarity. Also cleaned up the code within `adjustNDensForHotHeight` to be simpler and more efficient (instead of completely recalculating the number densities previously calculated in `setNDensFromMassFracsAtTempInC`, it now just scales them accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #657 introduced a bug into how number densities are initialized for a component.
The bug:
detailedAxialExpansion: True, number densities were being initialized with input temperatures.This is incorrect behavior as number densities should be initialized with hot temperatures to account for radial expansion of components. Otherwise, number densities are never adjusted for radial expansion and masses are incorrect.
This PR fixes this by initializing the number densities with hot temperatures. Accounting for axial expansion via
inputHeightsConsideredHotis then accounted for inadjustNDensForHotHeight.adjustNDensForHotHeightto be simpler and more efficient (instead of completely recalculating the number densities previously calculated insetNDensFromMassFracsAtTempInC, it now just scales them accordingly.Checklist
docfolder.setup.py.