Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number density bug fix #804

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Number density bug fix #804

merged 8 commits into from
Aug 3, 2022

Commits on Aug 1, 2022

  1. bug fix for init'ing num densities on Components 

    - The number densities in `applyMaterialMassFracsToNumberDensities` should be evaluated at hot temperatures to account for radial expansion of the components.
    @albeanth
    albeanth committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    2459aae View commit details
    Browse the repository at this point in the history

  2. change method name and docstring for clarity

    @albeanth
    albeanth committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    68f4ee2 View commit details
    Browse the repository at this point in the history

  3. change method name + update docstrings

    @albeanth
    albeanth committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f36edb9 View commit details
    Browse the repository at this point in the history

  4. simplifying adjustNDensForHotHeight 

    - instead of completely recalculating the number densities calculated by setNDensFromMassFracsAtTempInC, this now just scales the number densities accordingly. is an efficiency and clarity improvement
    @albeanth
    albeanth committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    1aa57fa View commit details
    Browse the repository at this point in the history

  5. release notes update

    @albeanth
    albeanth committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    158a6f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. codify code behavior more rigorously in unit tests

    @onufer
    onufer authored Aug 2, 2022
    Configuration menu
    Copy the full SHA
    360578d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. name change

    @onufer
    onufer authored Aug 3, 2022
    Configuration menu
    Copy the full SHA
    cc67758 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into numberDensityBugFix

    @jakehader
    jakehader authored Aug 3, 2022
    Configuration menu
    Copy the full SHA
    53709f9 View commit details
    Browse the repository at this point in the history