Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give the location in the repo of release notes in PR template #856

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Give the location in the repo of release notes in PR template #856

merged 1 commit into from
Aug 24, 2022

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Aug 24, 2022 •
edited
Loading

Description

This just removes some confusion that at least two people had when making a PR into ARMI.

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@jakehader jakehader merged commit 01f0185 into terrapower:main Aug 24, 2022
@opotowsky opotowsky deleted the notes_location branch August 24, 2022 21:32
@john-science john-science added the documentation Improvements or additions to documentation label Aug 25, 2022
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@opotowsky @scottyak
Give the location in the repo of release notes (terrapower#856)
0fa963a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakehader jakehader jakehader approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opotowsky @jakehader @john-science