Removing user defined blueprints from snapshot runs #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Testing impacts on downstream projects. Reverting to draft. |
- blueprints assemblies should be numbered 0 to len(assemDesigns). This should help guarantee that there are no name conflicts with blueprints assemblies and those in core.
albeanth
force-pushed
the
dbLoadUpdate
branch
from
49f9265
to
77411cd
Compare
- assertion now only counts core + sfp without blueprints assems. - Not counting blueprints assems stems from this change here terrapower@77411cd
- There are some cases where a database may not have blueprints, so a user will need to provide them. - However, for snapshot runs, we still do not allow user defined blueprints.
albeanth
changed the title
onufer
approved these changes
Sep 14, 2022
armi/reactor/blueprints/__init__.py
Outdated
| # retrieve current count of assemblies to restore after | ||
| # creating blueprints assemblies. This is particularly useful for | ||
| # doing snapshot based runs with database loads where the | ||
| # assembly counter is likely not equal to 0. |
There was a problem hiding this comment.
Add "To ensure that the assembly count is not a function of how many times load state/snapshots has been called"
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
* Subsequent DB loads no longer cause the assembly count to increase (due to blueprints)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing a snapshots run, ARMI allows users to use both new settings and blueprints. This PR removes the ability to use new (potentially different) blueprints.
Effects:
More relevant information can be found in #871. This PR will close #871 as well.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.