Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call completeInitialLoading after applying thermal expansion to the reactor core. #885

Merged
merged 4 commits into from Sep 19, 2022

Conversation

jakehader
Copy link
Member

Add fix in applyThermalExpansion to the reactor to call the block's completeInitialLoading method. This method is required to be called as it sets initial BOL values on each block, like heavy metal mass/moles on itself and its components. Additionally, this sets the smear density and initial enrichment

Description


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

…ompleteInitiaLoading method. This method is required to be called as it sets initial BOL values on each block, like heavy metal mass/moles on itself and its components. Additionally, this sets the smear density and initial enrichment
@jakehader jakehader added the bug Something is wrong: Highest Priority label Sep 19, 2022
@jakehader jakehader changed the title Call completeInitialLoading after applyingThermalExpansion on the reactor core. Call completeInitialLoading after applying thermal expansion to the reactor core. Sep 19, 2022
@jakehader jakehader merged commit e1e4816 into main Sep 19, 2022
@jakehader jakehader deleted the completeload branch September 19, 2022 05:55
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
… reactor core. (terrapower#885)

Add fix in applyThermalExpansion to the reactor to call the block's completeInitialLoading method. This method is required to be called as it sets initial BOL values on each block, like heavy metal mass/moles on itself and its components. Additionally, this sets the smear density and initial enrichment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants