Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call completeInitialLoading after applying thermal expansion to the reactor core. #885

Merged
merged 4 commits into from Sep 19, 2022
Merged

Call completeInitialLoading after applying thermal expansion to the reactor core. #885

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17f0937
Add fix in applyThermalExpansion to the reactor to call the block's c…
jakehader Sep 19, 2022
6495f8a
Add release note
jakehader Sep 19, 2022
f159ed7
Update unit tests to cover the parameter updates with block.completeI…
jakehader Sep 19, 2022
0fffc33
Reset import order changes
jakehader Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions armi/reactor/reactors.py
View file
Open in desktop
Expand Up @@ -2355,3 +2355,4 @@ def _applyThermalExpansion(
if not a.hasFlags(Flags.CONTROL):
for b in a:
b.p.heightBOL = b.getHeight()
b.completeInitialLoading()
1 change: 1 addition & 0 deletions doc/release/0.2.rst
View file
Open in desktop
Expand Up @@ -58,6 +58,7 @@ Bug fixes
#. Fixed bug where components were different if initialized through blueprints vs init (bug active for ~ 2 months).
#. Fixed bug where component mass was being conserved in axial expansion instead of correct density (`PR#846 <https://github.com/terrapower/armi/pull/846>`_)
#. Fixed bug in ``armi/reactor/blocks.py::HexBlock::rotatePins`` that failed to modify pinLocation parameter (`#855 <https://github.com/terrapower/armi/pull/855>`_).
#. Fixed bug in ``armi/reactor.py::Core::_applyThermalExpansion`` that failed to call the ``block.completeInitiaLoading`` (`#885 <https://github.com/terrapower/armi/pull/885>`_).
#. TBD

ARMI v0.2.3
Expand Down