Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing fictitious import #906

Merged
merged 1 commit into from Sep 28, 2022
Merged

Removing fictitious import #906

merged 1 commit into from Sep 28, 2022

Conversation

john-science
Copy link
Member

Description

This import doesn't exist, so I'm removing it.

Also: I removed a usage of the term "whitelist".

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Sep 28, 2022
opotowsky
opotowsky approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh good catch.

@john-science john-science merged commit 229af5c into main Sep 28, 2022
@john-science john-science deleted the rm_bad_import branch September 28, 2022 19:07
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Removing fictitious import (terrapower#906)
9680df5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@john-science @opotowsky