Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of shuffles in restart cases #941

Merged
merged 15 commits into from
Oct 22, 2022

Conversation

keckler
Copy link
Member

@keckler keckler commented Oct 17, 2022

Description

This closes #940 by simply adding to the logic in the interactBOC() hook of the fuel handler. See the description there for an overview of the problem.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@keckler keckler marked this pull request as draft October 17, 2022 20:59
@keckler keckler marked this pull request as ready for review October 17, 2022 21:44
@john-science john-science merged commit deb7c0f into terrapower:main Oct 22, 2022
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@keckler keckler deleted the shuffle branch November 24, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuel shuffling may duplicate in restart cases
2 participants