Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplication of shuffles in restart cases #941

Merged
merged 15 commits into from
Oct 22, 2022
Merged

Fix duplication of shuffles in restart cases #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7439a46
Lookup nuclides in the ISOTXS based on their nuclide labels
keckler Aug 3, 2022
bf5c629
Add tests on getReactionRates and getReactionRateDict
keckler Aug 3, 2022
8e6d110
Add to the changelog
keckler Aug 3, 2022
3491057
Merge branch 'terrapower:main' into main
keckler Aug 3, 2022
e30afaa
Merge branch 'main' of https://github.com/terrapower/armi
keckler Aug 9, 2022
3008c03
Merge branch 'main' of https://github.com/keckler/armi
keckler Sep 22, 2022
1b28757
Merge branch 'main' of https://github.com/terrapower/armi
keckler Sep 22, 2022
6ce53ae
Merge branch 'terrapower:main' into main
keckler Sep 28, 2022
921a48d
Merge branch 'terrapower:main' into main
keckler Sep 30, 2022
5d1dd0b
Fix duplicate shuffles in restart cases
keckler Oct 17, 2022
ea53fb1
Merge branch 'terrapower:main' into main
keckler Oct 17, 2022
eb41443
Merge branch 'main' of https://github.com/keckler/armi into shuffle
keckler Oct 17, 2022
3d1b5e9
Update changelog
keckler Oct 17, 2022
2b6cbd2
Fix logic
keckler Oct 17, 2022
8f8a824
Move the changelog entry to the correct spot whoops
keckler Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion armi/physics/fuelCycle/fuelHandlerInterface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,15 @@ def interactBOC(self, cycle=None):
)
mc2.interactBOC(cycle=cycle)

if self.enabled():
if self.enabled() and (
self.cs["loadStyle"] != "fromDB"
or self.cs["startNode"] == 0
or (self.cs["startCycle"] != cycle)
):
# in restart cases, only do this if restarting at BOC to avoid duplicating shuffles
# the logic to accomplish this is a bit long because we don't pass the
# timeNode into interactBOC hooks. Otherwise it would be much easier
# to determine when to call this or not
self.manageFuel(cycle)

def interactEOC(self, cycle=None):
Expand Down
1 change: 1 addition & 0 deletions doc/release/0.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ What's new in ARMI
Bug fixes
---------
#. Fixed bug in ``fastFlux`` block parameter mapping in the ``UniformMeshConverter`` by applying it to the ``detailedAxialExpansion`` category.
#. Fixed issue where shuffles might duplicate in restart runs.


ARMI v0.2.4
Expand Down