Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused TH parameters #981

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Removing unused TH parameters #981

merged 1 commit into from
Nov 18, 2022

Conversation

john-science
Copy link
Member

Description

Thanks to @andfranklin for finding these dead parameters!


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Nov 18, 2022
@john-science john-science linked an issue Nov 18, 2022 that may be closed by this pull request
@john-science
Copy link
Member Author

The code coverage went down because the total number of lines of code went down.

That's fine.

@john-science
Copy link
Member Author

@andfranklin Just FYI. The first PR is up.

@john-science john-science merged commit 474534b into main Nov 18, 2022
@john-science john-science deleted the dead_th_params branch November 18, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TH Param Spring Cleaning: dead parameters
2 participants