Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused ARMI Parameters #986

Merged
merged 4 commits into from Nov 19, 2022
Merged

Removing unused ARMI Parameters #986

merged 4 commits into from Nov 19, 2022

Conversation

john-science
Copy link
Member

Description

Due to recent discussion, I have been taking an inventory of all the Parameters in ARMI, and scouring our downstream repositories to see which are used and which are not. The Parameters removed in this PR appear to have all been abandoned and totally unused for at least four years, in all downstream projects I have access to.

I have tested this PR against a few dozen of the biggest and most complex downstream repositories, and it passes muster.

Specifically, I have removed defunct Parameters from:

  • Economics
  • Flux Reconstruction
  • Thermal Hydraulics

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added cleanup Code/comment cleanup: Low Priority feature request Smaller user request labels Nov 18, 2022
@john-science
Copy link
Member Author

@drewj-usnctech Just FYI.

If you guy use any of these Parameters, I can keep them in. Or you can copy/paste them into your own plugins. Or something. I just didn't want to blind side you.

@john-science
Copy link
Member Author

The code coverage went down because I removed code.

Nothing for it.

@john-science john-science merged commit 9927cac into main Nov 19, 2022
@john-science john-science deleted the rm_dead_params branch November 19, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants